Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation #178

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Conversation

jwworth
Copy link
Contributor

@jwworth jwworth commented Mar 22, 2018

Thank you for building and maintaining this project!

I've been reading this documentation trying to fix a bug, and found a code example that could be clearer. I fixed a few typos along the way.

Thanks again!

@RobertDober
Copy link
Collaborator

Thank you for your PR, appreciated.(I'd sworn to precede took 4 'e's).

Just a little note, are you aware that you have removed one doctest example ?

I'll put it back after the merge :)

@RobertDober RobertDober merged commit 60a4a12 into pragdave:master Mar 22, 2018
@RobertDober
Copy link
Collaborator

@jwworth I just forgot and will fix it by hand, but for your info.

All you did will be overwritten by our build process, I need to document that as all code related information in the README is generated from docstrings. (so even I do not forget)

RobertDober added a commit that referenced this pull request Mar 22, 2018
@jwworth
Copy link
Contributor Author

jwworth commented Mar 22, 2018

@RobertDober makes sense; thanks for the explanation.

@jwworth jwworth deleted the clarify-documentation branch March 22, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants